console-rs / console-rs/console

Make more use of `Read` and `Write`

Open
#108 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
144
Avg merge
8h 24m
Merged PRs (30d)
4

Description

Creating a Term from Read and Write was added in #34 (merged #93 ) which is pretty cool 🎉
I am using that mechanism to write a TestTerminal that buffers calls to Write internally and has prepared content for Read.

My code uses term.read_line() though, which to my surprise uses stdin() directly.
I was expecting that to go through Read.

Is that something that could be adjusted? I can probably try and submit a PR?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the term.read_line() entry point and trace how it currently obtains input versus the Read and Write mechanisms used to create a Term. Confirm the expected behavior with a TestTerminal that buffers Write calls and provides Read content; done means read_line() uses Read rather than stdin directly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.