confluentinc / confluentinc/vscode

E2E: update `Quickpick` page object model to optionally filter by `title` and enforce locator visibility before interactions

Open
#2,740 0 comments 0 reactions 0 assignees View on GitHub
testing
Dominant language
TypeScript
Stars
34
Forks
17
Avg merge
1d 22h
Merged PRs (30d)
8

Description

Granted only one quickpick can be visible at a time, but we should be able to specify what we expect to see:
https://github.com/confluentinc/vscode/blob/9fe8437d825d6d7d3c0cc677079554894e8581e3/tests/e2e/objects/quickInputs/Quickpick.ts#L6-L12

We have some areas where we need to auto-await/-retry the quickpick element being visible before interacting:
https://github.com/confluentinc/vscode/blob/9fe8437d825d6d7d3c0cc677079554894e8581e3/tests/e2e/utils/connections.ts#L236-L237

But that isn't [always the case](https://github.com/search?q=repo%3Aconfluentinc%2Fvscode%20%22%3D%20new%20Quickpick(%22&type=code), so some preventative action here would be helpful

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.