confluentinc / confluentinc/vscode

Mark connection test as failed if sidecar returns validation error

Open
#2,702 0 comments 0 reactions 0 assignees View on GitHub
direct connection/resources
Dominant language
TypeScript
Stars
34
Forks
17
Avg merge
1d 22h
Merged PRs (30d)
8

Description

The direct connection form allows users to test connecting to a Kafka cluster or Schema Registry before saving the connection. If the sidecar failed to connect to the resource, the direct connection form marks the connection as failed:

Image

The sidecar validates all provided fields before attempting the connection. If fields violated the validation rules, it returns a client-side HTTP error. At the moment, the direct connection form renders a green check mark above the form if the sidecar returns a validation error:

Image

It should show an error notification, similar to the first screenshot, instead.

Also, for OAuth credentials, we should validate the client secret in the direct connection form. I captured it separately: https://github.com/confluentinc/vscode/issues/2703

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.