confluentinc / confluentinc/vscode

Update `extractResponseBody()` to accept `Response`s and use generic type instead of `any`

Open
#2,683 0 comments 0 reactions 1 assignee Claimed by @shouples View on GitHub
cleanup
Dominant language
TypeScript
Stars
34
Forks
17
Avg merge
1d 22h
Merged PRs (30d)
8

Description

There isn't any reason we should only match `AnyResponseError` since the logic could be helpful for any `Response`s we get from direct fetch requests. Plus we want to get away from `any` usage in general, so callers should have somewhat of an idea what to expect.

https://github.com/confluentinc/vscode/blob/fac15b41a3554e28e1273eab4e498d99d01b0d30/src/errors.ts#L63

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.