confluentinc / confluentinc/vscode

Fix five tests failing as a result of `gulp apigen` with a v3.1.x OpenAPI spec

Open
#2,085 0 comments 0 reactions 0 assignees View on GitHub
cleanup testing
Dominant language
TypeScript
Stars
34
Forks
17
Avg merge
1d 22h
Merged PRs (30d)
8

Description

From:
https://semaphore.ci.confluent.io/jobs/a8417c38-1c65-4dbf-9e8f-b616fd79a7c1/summary?report_id=89b0cca0-714f-3dad-a1e6-25d83d181802&test_id=7441d119-65d3-33df-9fd7-78ae7868ea68
- `CustomConnectionSpec object conversion`:
- `should correctly convert objects to typed CustomConnectionSpecs` and `should correctly convert a typed CustomConnectionSpec to a plain object` both expect `credentials` and `ssl` keys whose values are `undefined`, but the object doesn't have those keys at all
- `WebsocketManager.parseMessage tests`
- `parseMessage vs good message structure tests` similar to the two tests above, expected an `organization_id` key with `undefined`, but didn't get any `organization_id` key at all

- `chat/summarizers/connections.ts`
- `summarizeConnection() should summarize a `LOCAL` connection` and `summarizeLocalConnection() should show Schema Registry as running and include the URI when available`:
- ```
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

assert__namespace.ok(result.includes(`URI: ${tests_unit_testResources_schemaRegistry.TEST_LOCAL_SCHEMA_REGISTRY.uri}`))
```

Test using a sidecar OpenAPI spec before it reverted back to (OpenAPI) version 3.0.3: https://github.com/confluentinc/ide-sidecar/blob/dd534b9d8589895502a3952264c5f361c73374a8/src/generated/resources/openapi.yaml

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.