confluentinc / confluentinc/rest-utils

NPE in MetricsRequestEventListener when @PreMatching ContainerRequestFilter throws exception.

Open
#158 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
25
Forks
211
Avg merge
14h 33m
Merged PRs (30d)
3

Description

I registered a @PreMatching ContainerRequestFilter via kafka.rest.resource.extension.class and sometimes need to throw exceptions that are mapped to responses. This works fine (client gets the correct response), but the MetricsRequestEventListener logs a NPE.

Root cause: The event RequestEvent.Type.MATCHING_START is never invoked in this case (exception is thrown in PreMatching filter), thus never initializing the wrappedRequestStream field. Later, handling the FINISHED event assumes wrappedRequestStream is set, throwin the NPE.

I believe MetricsRequestEventListener must be patched to initialize the `wrappedRequestStream` and `started` without depending on MATCHING_START event, because in this case it is never triggered.

I'm thinking about the following alternative to fix the issue: Replace the condition `if (event.getType() == RequestEvent.Type.MATCHING_START)` by `if (started == 0L)` or `if (wrappedRequestStream == null)` (at https://github.com/confluentinc/rest-utils/blob/5.3.1-post/core/src/main/java/io/confluent/rest/metrics/MetricsResourceMethodApplicationListener.java#L301) to initialize variables the first time any event is triggered.

I'll open a PR.

Cheers,

Fabio

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.