confluentinc / confluentinc/ksql

Consider removing the concept of terminating a query

Open
#3,967 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
315
Forks
1k
Avg merge
1d 7h
Merged PRs (30d)
36

Description

With reference to the [PR that introduced `TERMINATE ALL` syntax](https://github.com/confluentinc/ksql/pull/3944).

We might look to remove the concept of terminating queries at all. We offer no way of restarting a terminated query, so why off a way to terminate?

If we choose to introduce a way to restart a query, then terminating actually means something. Restarting would be useful for re-kicking a failed query. However, there are probably better ways of handling failed queries. After all, a traditional db does not expose the state of the processing used to build a materialized view.

Removing `terminate` would address issues such as:
* https://github.com/confluentinc/ksql/issues/2112
* https://github.com/confluentinc/ksql/issues/1317
* https://github.com/confluentinc/ksql/issues/2177

Contributor guide

Open the contributing guide

Research direction

Start by reading PR #3944, which introduced TERMINATE ALL syntax, then review linked issues #2112, #1317, and #2177 for the existing problems. Done requires a decided direction on removing termination or supporting restart, followed by identifying the affected query behavior and validating the resulting design.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, sql
Domain
databases, stream-processing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.