confluentinc / confluentinc/examples

Examples Should Avoid Using Schema Registry for Keys

Open
#817 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.1k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

I don't think it's commonly understood by new learners that using Schema Registry for keys is bad practice (see this internal confluent [slack convo](https://confluent.slack.com/archives/GALQHUBEG/p1598908733004000) ). For example, if you reorder fields, it will break partitioning. Also protobuf and json schemas don't serialize deterministically, so using those formats for keys will also break partitioning.

[This python example](https://github.com/confluentinc/examples/tree/6.0.0-post/clients/cloud/python) uses Avro for the key `Name` and it probably shouldn't.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.