confluentinc / confluentinc/common

common-config transitively depends on, but does not use, zookeeper and netty

Open
#203 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
17
Forks
243
Avg merge
1d 21h
Merged PRs (30d)
38

Description

common-utils defines dependencies on both zookeeper and zkclient, which transitively include netty 3.10.6.Final. common-config depends on common-utils, but does not use any zookeeper-related functionality, however it still transitively pulls along zookeeper and netty libs, and anything with a transitive dependency on common-config gets those too.

We have an application that uses kafka-avro-serializer, with transitive deps on common-config, common-util, zookeeper, and netty 3.10.6.Final. We're also using an http client lib that pulls in (and actually uses) netty 4.1.33.Final, and we tracked down a `NoClassDefFoundError` to having both netty 4 and 3 libs on the classpath.

Since common-config doesn't use any zookeeper/netty stuff, it's probably a good idea that it does not pull along those jars. Maybe exclude them in common-config pom, or extract out a new common-util-zookeeper lib?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.