conductor-oss / conductor-oss/csharp-sdk

TaskResult.StatusEnum values are wrong, should be one value lower.

Open
#92 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
54
Forks
23
Avg merge
4d 21h
Merged PRs (30d)
2

Description

See: https://github.com/conductor-sdk/conductor-csharp/blob/ec6a079113826782d26c83b6b5b6d037860cfc9c/Conductor/Client/Models/TaskResult.cs#L23

Experimentally, I found these values to be wrong. Instead, I found them all to be one value lower than the values in code. The values should be zero based, not one based. What I think the correct code is:

```
[JsonConverter(typeof(StringEnumConverter))]
public enum StatusEnum
{
///
/// Enum INPROGRESS for value: IN_PROGRESS
///
[EnumMember(Value = "IN_PROGRESS")]
INPROGRESS = 0,
///
/// Enum FAILED for value: FAILED
///
[EnumMember(Value = "FAILED")]
FAILED = 1,
///
/// Enum FAILEDWITHTERMINALERROR for value: FAILED_WITH_TERMINAL_ERROR
///
[EnumMember(Value = "FAILED_WITH_TERMINAL_ERROR")]
FAILEDWITHTERMINALERROR = 2,
///
/// Enum COMPLETED for value: COMPLETED
///
[EnumMember(Value = "COMPLETED")]
COMPLETED = 3,
}

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.