conductor-oss / conductor-oss/csharp-sdk
ApiClient using obsolete (currently deprecated) RestClientOptions property
- Dominant language
- C#
- Stars
- 54
- Forks
- 23
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 2
Description
In a constructor for ApiClient, a RestClient is newed up as follows:
```
RestClient = new RestClient(options: new RestClientOptions() { BaseUrl = new Uri("https://play.orkes.io/api"), MaxTimeout = timeOut });
```
The option property "MaxTimeout" was marked obsolete with backwards compatibility up through RestSharp v112.
https://restsharp.dev/docs/v111/changelog/#v1110 RestSharp v113 and beyond no longer support this backwards compatibility.
The newer versions use `public TimeSpan? Timeout { get; set; }`
I'm requesting this be updated to something _functionally_ along the lines of:
```
RestClient = new RestClient(options: new RestClientOptions
{
BaseUrl = new Uri("https://play.orkes.io/api"),
Timeout = TimeSpan.FromMilliseconds(timeOut)
});
```
in order to be compatible with the latest versions of RestSharp.
Thanks!
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.