conductor-oss / conductor-oss/conductor

conductor oss v3.21.19 cannot send metrics to datadog

Open
#699 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
32.2k
Forks
1k
Avg merge
2d
Merged PRs (30d)
33

Description

**Describe the bug**
Conductor is deployed to k8s with below settings

```
conductor.metrics-datadog.enabled=true
management.datadog.metrics.export.enabled=true
management.datadog.metrics.export.apiKey=${DD_API_KEY}
management.datadog.metrics.export.application-key=${DD_APP_KEY}
management.datadog.metrics.export.uri=
management.datadog.metrics.export.step=10s
management.metrics.tags.env=test
```

Above works fine until I upgrade from v3.21.14 to v3.21.19 - conductor metrics cannot be sent to datadog dashboards.
Every config keep the same, I revert back to v3.21.14 - conductor metrics can be sent and shown in datadog dashboards

v3.21.19 at start up it has logs:
```
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - =========
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - Conductor configured with 4 metrics registries
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - Metrics registry: io.micrometer.datadog.DatadogMeterRegistry@59929ac
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - Metrics registry: io.micrometer.jmx.JmxMeterRegistry@de63949
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - Metrics registry: io.micrometer.prometheusmetrics.PrometheusMeterRegistry@77881b7a
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - Metrics registry: org.springframework.boot.actuate.autoconfigure.metrics.AutoConfiguredCompositeMeterRegistry@180d918a
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - check https://docs.micrometer.io/micrometer/reference/ for configuration options
9302 [main] INFO com.netflix.conductor.contribs.metrics.MetricsCollector [] - =========
```
but in v3.21.14 there are no such logs printed.

I also noticed that settings.gradle v3.21.19 removed below dependency. Just for your reference.
include 'client'
include 'client-spring'

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.