conductor-oss / conductor-oss/conductor
[BUG] Acknowledging all the tasks is incorrect
- Dominant language
- Java
- Stars
- 32.2k
- Forks
- 1k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 37
Description
https://github.com/conductor-oss/conductor/blob/b4da79cddc9dd2228a0bb535e16f310630c8df17/core/src/main/java/com/netflix/conductor/service/ExecutionService.java#L206
As the code line highlighted above could lead to some of the tasks put in progress without being polled by the worker.
My Use case:
I have parallel tasks which are being created dynamically in FORK_JOIN_DYNAMIC, here my worker is not a batch processor, it just polls only a single task and marks it as IN PROGRESS, due the above logic, my worker is able to poll one task and other task are NOT being polled as the above line marks all the task as ackTaskRecieved, which I believe is not correct.
we should have some flag kind of thing, based on that acking all the tasks make sense, instead of acking all the tasks from the queue blindly.
Open for suggestions ?
@gustavo.gardusi@gmail.com
Contributor guide
Assessment
This issue has not been assessed yet.