conductor-oss / conductor-oss/conductor
Improve http connection test
- Dominant language
- Java
- Stars
- 32.2k
- Forks
- 1k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 41
Description
This appears to be a test that attempts a timeout. The test asserts that the entire timeout occurred, but that isn't the only failure condition. Some valid networks can respond that the network address is unreachable in less time than the timeout. Instead of using an rfc1918 address, expecting a full time out it would be better to select an address from 127/8 (eg 127.1.2.3) that should do as the code intends, wait the full timeout for a connection failure.
https://github.com/conductor-oss/conductor/blob/b71d28b29e127504788c3d760231caaa0c89146a/http-task/src/test/java/com/netflix/conductor/tasks/http/HttpTaskTest.java#L298
Contributor guide
Research direction
Open http-task/src/test/java/com/netflix/conductor/tasks/http/HttpTaskTest.java at the referenced test near line 298 and inspect how the timeout failure is asserted. Run the targeted HTTP task test, then verify the revised case uses a 127/8 address and checks the intended connection-failure behavior without depending on an RFC1918 network timing out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- networking, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100