conductor-oss / conductor-oss/conductor-cli

Move the agent client to the Go SDK

Open
#110 0 comments 0 reactions 1 assignee Claimed by @mp-orkes View on GitHub
enhancement
Dominant language
Go
Stars
11
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Follow-up to #109 (`internal/agent/client.go`): the agent client should live in the [Go SDK](https://github.com/conductor-oss/go-sdk), not here.

## Why

- **Every other SDK already owns this.** Java has `AgentClient`/`OrkesAgentClient` plus a typed `AgentRequest`; Python has `agent_client.py`/`orkes_agent_client.py`.
- **The CLI is already an SDK consumer.** It depends on `github.com/conductor-sdk/conductor-go` and `internal/agent` is the only resource area with a bespoke client on `internal/transport`.
- **Avoid duplication.** The wire DTOs are private to the CLI. Nothing cross-checks them against the server's `AgentStartRequest`. `Compile` posted a bare config while `Run` wrapped it, and the mismatch went unnoticed.
- **Nobody else can use it.** Under `internal/`, the agent API is unreachable outside CLI.

## Scope

Move the client and models to the SDK; keep the CLI's command and UX layer here.

- Move: the REST client, the DTOs, the agent/execution models.
- Keep: SSE stream rendering, interactive prompts, and `service.go` orchestration (`detectFramework`, register-then-run) — these are CLI concerns.
- Then replace `internal/agent`'s client with the SDK's and bump the pinned SDK version.

No user-facing behaviour change intended.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.