conda / conda/constructor

Add additional environment variables to MSI installers

Open
#1,279 1 comment 0 reactions 0 assignees View on GitHub
type::feature
Dominant language
Python
Stars
497
Forks
181
Avg merge
1d 16h
Merged PRs (30d)
17

Description

### Checklist

- [x] I added a descriptive title
- [x] I searched open requests and couldn't find a duplicate

### What is the idea?

In the PR https://github.com/conda/constructor/pull/1277 it was noted that environment variables such as `INSTALLER_PATH` and `INSTALLER_PLUGINSDIR` are not set by MSI installers (but are for EXE).
These should also be set similarly for MSI Installers.

### Why is this needed?

To create a similar UX between the two Windows installer types, especially since installer builders may have pre/post uninstall/install scripts that depend on these.

### What should happen?

Environment variables `INSTALLER_PATH` and `INSTALLER_PLUGINSDIR` should be set. The `INSTALLER_PATH` is straight-forward but the variable `INSTALLER_PLUGINSDIR` needs some additional discussion since it is NSIS specific.

### Additional Context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by comparing the MSI installer handling with the EXE behavior referenced in PR 1277. Determine how INSTALLER_PATH is derived and resolve the expected MSI meaning of INSTALLER_PLUGINSDIR, then verify that both environment variables are available to relevant installer scripts for each Windows installer type.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, release
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.