conda-forge / conda-forge/llvmdev-feedstock

Build shared lib on windows?

Open
#237 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
12
Forks
54
Avg merge
4h 15m
Merged PRs (30d)
3

Description

This recently came up in #213, where I noted:
> I see [@isuruf] added the `=NO` on windows in https://github.com/conda-forge/llvmdev-feedstock/commit/8059f3a076bfc1770ab993c22e882fc7279e66a3 (though I don't see relevant comments in the corresponding [PR](https://github.com/conda-forge/llvmdev-feedstock/pull/66)). That commit is also relevant because it introduced another point about this recipe I'm not 100% sure about - currently on windows, `libllvm16` & `llvm` are completely empty packages - I presume because this would be for the shared libraries which we're not building currently.

I've also just stumbled across https://github.com/apache/arrow/pull/37412, which does
```cmake
if(MSVC)
# It seems that conda's llvmdev for Windows doesn't provide shared
# library.
set(ARROW_LLVM_USE_SHARED_DEFAULT OFF)
else()
set(ARROW_LLVM_USE_SHARED_DEFAULT ${ARROW_DEPENDENCY_USE_SHARED})
```

Would appreciate your input @isuruf on whether we should do this at all, and what blockers (if any) you see.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.