conda-forge / conda-forge/faiss-split-feedstock
Can't rebuild with newer pip
- Dominant language
- Shell
- Stars
- 5
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
### Comment:
Hi,
I have a personal fork of faiss, for which I rely on the conda-forge feedstock to manage its builds. Today, new builds stopped working, including rebuilds of older versions. It appears that setuptools is no longer present during the build. setuptools is required here: https://github.com/conda-forge/faiss-split-feedstock/blob/b951667cfde9c2d36d3b15a58f2e52440e562c0e/recipe/build-pkg.sh#L43
I traced it back to a recent update to pip to 24.1.2 on conda-forge: https://github.com/conda-forge/pip-feedstock/pull/121 that removed setuptools as a dependency of pip itself. It looks like the this feedstock was relying on setuptools being installed through pip.
I fixed it by adding setuptools as a host dependency here: https://github.com/conda-forge/faiss-split-feedstock/blob/b951667cfde9c2d36d3b15a58f2e52440e562c0e/recipe/meta.yaml#L207
Hope this helps save a few minutes of debugging.
Contributor guide
Research direction
Start with recipe/meta.yaml at the host dependency section identified in the report, then read recipe/build-pkg.sh around the setuptools usage. Rebuild the feedstock with the newer pip behavior, including an older faiss version if available. Done means the build finds setuptools and completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100