concourse / concourse/semver-resource
[BUG] final bump from RC doesn't print bump information
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 99
- Forks
- 109
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 4
Description
This code works well for me in every case I've tested it, except for when trying to bump final an input of the type 1.2.3-rc.1. The resource appears to bump correctly to 1.2.3 when I look at the next steps of the job, but it does NOT print the exptected
bumped locally from 1.2.3-rc.1 to 1.2.3
Which makes it look like the input version was NOT bumped.
It's possible that this compare function isn't doing the right thing. But both the tests and the code seem pretty convincing to me at first glance.
cc: @adobley
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in main.go at the linked bump logic and reproduce the final bump for 1.2.3-rc.1. Inspect the linked vendor/github.com/blang/semver/semver.go compare function if needed; done means the bump reaches 1.2.3 and prints that it was bumped locally from 1.2.3-rc.1 to 1.2.3.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100