concourse / concourse/pool-resource

Get behaviour does not match README

Open
#31 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Go
Stars
59
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Using Concourse 3.5.0 and the pool-resource we expected a 'get' to only return when an acquired lock was available. However, the behavior we see is that we are returned the latest resource version for the git repo backing the pool, regardless of a locks state.

The README for this resource states: in: Fetch an acquired lock.

Should the get behavior be to only get acquired locks, or get any lock?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README section stating that in fetches an acquired lock, then trace the resource's get behavior to compare it with the reported result for the pool's backing git repository. Confirm the intended semantics for acquired versus any locks, and make the behavior and documentation agree; no test or source path is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.