concourse / concourse/git-resource

Change in git_config results in inability to use combined ca certs

Open
#476 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Shell
Stars
203
Forks
305
Avg merge
11d 14h
Merged PRs (30d)
2

Description

Describe the bug

https://github.com/concourse/git-resource/pull/457

The change results in different behaviour depending on if you're looking at a native git resource in concourse or a custom script.

Could a variable please be created for opting out and using the original behaviour where custom script/container can use the default store for ca certs?

Reproduction steps
  1. deploy concourse onto k8s, using workerAdditionalCerts, ensure certsPath is set on the workers in the helm chart
  2. configure git resource in concourse pipeline with git_config - name: http.sslCAInfo value: /etc/ssl/certs/worker-additional-certs.pem
  3. Notice Concourse is able to clone the repo nicely
  4. create job with script which uses custom image which cds to repo and git pull. note the error as the path to /etc/ssl/certs/worker-additional-certs.pem is no longer valid as Concourse has expanded all certs into separate files and /etc/ssl/certs/worker-additional-certs.pem no longer exists
    ...
Expected behavior

Concourse can clone repos nicely using specific ca certs
Concourse can also run scripts with custom images for various distros and use the system ca-cert store. not necessarily inheriting from the original resource

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading pull request #457, then trace how git_config, workerAdditionalCerts, and certsPath are handled when certificates are expanded. Compare native resource cloning with custom-image git usage and define how an opt-out would preserve the system CA store. Done means both workflows can use the intended CA certificates without breaking the other.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, helm, kubernetes, shell
Domain
devops, infrastructure, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.