concourse / concourse/docker-image-resource
Doesn't cope with private registry with no '.' in hostname
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 162
- Forks
- 250
- PR merge metrics
- No merged PRs in 30d
Description
If your private registry does not contain a '.', then due to the logic in the following code, the function assumes that you are not using a private registry and attempts to use docker hub.
Scenarios like this can crop up when concourse and your registry are on the same network, say within a docker network.
I'm using nexus for my private docker registry/proxy, but if I use the docker FQDN when logging in I get an HTTP 400; yes this is a Nexus issue, but the assumption in the code above is still wrong.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in assets/common.sh at line 105 and inspect how registry hostnames are classified before Docker Hub is selected. Reproduce the case with a private registry hostname that has no dot; done means the resource selects that registry rather than Docker Hub.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100