concourse / concourse/concourse-chart
Default values for secrets in values.yaml is not safe
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 160
- Forks
- 189
- PR merge metrics
- No merged PRs in 30d
Description
The way secrets are being handled in this helm chart is not optimal and can lead to security holes. One might decide to provide a values.yaml file during deployment overriding the default keys (like this one: https://github.com/concourse/concourse-chart/blob/master/values.yaml#L1962) but if the chart at some point changes the name of the key, the override will do nothing an the deployment will happen with the default keys, which could be a security problem for public facing instances. No default private key or password should ever be in the default values.yaml file otherwise one would have to go through the whole file before every deployment or upgrade to make sure no default was added that should be overriden.
A better approach would be to run a job that generates all the needed secrets if they are not already there. Let me know what you think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the secret defaults in values.yaml, especially around line 1962, and trace how those values are used during chart deployment. Define the required secret-generation and preservation behavior, then verify that deployments and upgrades do not retain insecure default private keys or passwords when overrides are missing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100