concourse / concourse/concourse-chart
Make it possible to cleanup the workdir on workers startup for deployments
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 160
- Forks
- 189
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
Hi,
The variable worker.cleanUpWorkDirOnStart makes it possible to cleanup the workdir on workers startup but it's been implemented for statefulset only. Is there any good reason it's not implemented in deployments?
Nodes disk space keeps growing up because of unreleased disk space after a worker crashes, gets restarted or even upgraded.
Some may have good reasons for not using statefulsets: local high performance disks required, workers and nodes autoscaling, etc...
Describe the solution you'd like
I wish the cleanup initContainer was implemented in the worker deployment just like it is for statefulsets
I'd be happy to submit a patch
Describe alternatives you've considered
None that I can think of
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the existing StatefulSet implementation of worker.cleanUpWorkDirOnStart with the worker Deployment templates in this Helm chart. Confirm how the cleanup initContainer is configured for StatefulSets, then implement equivalent Deployment support and verify that rendered Deployment manifests include it when the setting is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100