concourse / concourse/concourse-chart

TLS secrets does not follow standard Kubernetes TLS secret format

Open
#224 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
160
Forks
189
PR merge metrics
No merged PRs in 30d

Description

Certificate created using cert manager and with kubectl create secret tls will generate a standardized secret like:

data:
  ca.crt: <redacted>
  tls.key: <redacted>
  tls.crt: <redacted>

Because the Conourse Helm Chart does not comply to this standard, it makes it impossible to have certificate provisioners automatically feed secrets to concourse. Certificate data needs to be manually duplicated and is not a safe practice.

An example would be https://github.com/concourse/concourse-chart/blob/94c54aa054fe53c5603114e881c26f38b3598d4a/templates/web-deployment.yaml#L300

- name: CONCOURSE_TLS_CERT
  value: "{{ .Values.web.tlsSecretsPath }}/client.cert"
- name: CONCOURSE_TLS_KEY
  value: "{{ .Values.web.tlsSecretsPath }}/client.key"

Sadly, I don't see an easy fix to this as it would involved refactoring all secret management for the entire helm chart. Maybe that could be considered for a future new major or minor version.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with templates/web-deployment.yaml, especially the CONCOURSE_TLS_CERT and CONCOURSE_TLS_KEY references, then trace how TLS secrets are managed across the chart. Compare the rendered secret keys with the Kubernetes TLS secret format; done means certificate provisioners can supply the standard secret without manual duplication.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.