conan-io / conan-io/docs

Missing package_type assignment in example documentation of "Package prebuilt binaries"

Open
#3,328 1 comment 0 reactions 1 assignee Claimed by @memsharded View on GitHub
Dominant language
C++
Stars
125
Forks
382
Avg merge
22h 39m
Merged PRs (30d)
21

Description

The example of [Package prebuilt binaries](https://docs.conan.io/2/tutorial/creating_packages/other_types_of_packages/package_prebuilt_binaries.html) does not mention the need to set an appropriate [package_type](https://docs.conan.io/2.0/reference/conanfile/attributes.html#reference-conanfile-attributes-package-type).

In case the **package_type** remains undefined, consumers using **CMakeDeps** generator will not have the a **_BIN_DIRS** variable defined in the generated finders, due to the explicit exclusion of such variable in [target_data.py:346](https://github.com/conan-io/conan/blob/release/2.0/conan/tools/cmake/cmakedeps/templates/target_data.py#L346).

As a result, users trying to use the example documentation to package a pre-existing shared library will most likely fail to run the *test_package* due to a missing DLL.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.