composer / composer/satis

Do we need to load all packages each times with providers enabled ?

Open
#556 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
3.3k
Forks
530
Avg merge
6h 53m
Merged PRs (30d)
13

Description

Hello,
On BuildCommand if we have a package/repository filter, we load all packages to dump them with the PackagesBuilder :
```
if ($packageSelection->hasFilterForPackages() || $packageSelection->hasRepositoryFilter()) {
// in case of an active filter we need to load the dumped packages.json and merge the
// updated packages in
$oldPackages = $packageSelection->load();
$packages += $oldPackages;
ksort($packages);
}

$packagesBuilder = new PackagesBuilder($output, $outputDir, $config, $skipErrors);
$packagesBuilder->dump($packages);
```

Is it really needed if providers option is enabled ?
If no, I can create a pull request to change the code

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.