composefs / composefs/composefs-rs
Mitigate generics
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 93
- Forks
- 30
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 13
Description
See https://github.com/bootc-dev/bootc/pull/1314#discussion_r2211627710
In live chat Allison was thinking we could at least pick a default hash value; that would very clearly help in reducing typing. Maybe we could make it a repository build time option?
But I still have a medium-strong opinion (as came up in the original PR https://github.com/containers/composefs-rs/pull/105 ) that it'd be better to just do dynamic dispatch in general.
There's variants here; e.g. we might keep generics for e.g. pub struct FileSystem.
I dunno though, I meant we already heap allocate for each filename, extended attribute and inline content, are we really winning by inlining RegularFile::External::ObjectId?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the discussion in bootc-dev/bootc#1314 and the original containers/composefs-rs#105 discussion. Compare the proposed default hash build option with broader dynamic dispatch, including which types might retain generics. Done requires an agreed approach and an implementation scope; no files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100