comphy-lab / comphy-lab/soapy

[BUG] Unknown argument `includeCoat` passed to `getFacet`

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Line 93 in file: [/postProcess/Video-generic.py](https://github.com/comphy-lab/soapy/blob/main/postProcess/Video-generic.py#L93)

This line passes argument `includeCoat` to the executable `getFacet`, but this argument is not known to `getFacet`. This leads `getFacet` to prematurely end with error code 1, in turn failing `Video-generic.py`.

Work-around solution:
Changing line 93 to
```py3
exe = ["./getFacet", filename] # , includeCoat]
```
resolves the issue.

The proper solution is probably to update [getFacet.c](https://github.com/comphy-lab/soapy/blob/main/postProcess/getFacet.c) and make it accept the `includeCoat` argument?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.