compat-table / compat-table/compat-table

Move the `Array.prototype.sort` `comparefn` test away from /es5/

Open
#1,176 24 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.5k
Forks
933
PR merge metrics
No merged PRs in 30d

Description

https://kangax.github.io/compat-table/es5/#test-Array_methods_Array.prototype.sort:_compareFn_must_be_function_or_undefined

This test has nothing to do with ES5. It’s a formerly undefined behavior that only [very recently](https://github.com/tc39/ecma262/commit/564b30b3b1bbba3772a2ebeb58208043713d64fe) (years after ES5 was published) got standardized. If anything, it’s an ES2018 feature.

Should this be moved from `…/es5/` to another page (e.g. `…/es2018/`)?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked Array.prototype.sort comparefn entry in the compat-table ES5 page and review the referenced ECMAScript commit. Determine the appropriate edition page, then move the test so it is no longer categorized under ES5 and verify the entry remains represented in the compatibility table.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.