compas-dev / compas-dev/compas

`Mesh.from_polyhedron(polyhedron)` should be renamed `from_platonicsolid`

Open
#858 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
386
Forks
122
Avg merge
11d 46m
Merged PRs (30d)
1

Description

## Expected Result

I expect `Mesh.from_polyhedron` to consume a Polyhedron class. Turns out it doesn't. This causes a slight semantic nuisance.

## Actual Result

Currently, the function takes an integer and constructs a platonic solid and turns that to mesh.

I think the current thing should be renamed `Mesh.from_platonicsolid(f)` and the function `Mesh.from_polyhedron` should follow the same implementation of `from_shape`. Note that I'm using Platonic solid

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.