compas-dev / compas-dev/compas

Result of meshes_join does not maintain face (vertex/edge) attributes

Open
#353 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
386
Forks
122
Avg merge
11d 46m
Merged PRs (30d)
1

Description

# Feature Request

As a designer, I want different faces in a compas mesh to have different attributes (e.g. based on function or material or...) so that e.g. further subdivision can be dependant on this attribute.

## Details

**Is your feature request related to a problem? Please describe.**
The current implementation of `meshes_join` ([here](https://github.com/compas-dev/compas/blob/master/src/compas/datastructures/mesh/join.py#L49)) completely disregards any attributes.

**Describe the solution you'd like**
Where the [faces get added](https://github.com/compas-dev/compas/blob/master/src/compas/datastructures/mesh/join.py#L75) to the new mesh, not only take into account vertex keys but also eventual existing attributes.

**Describe alternatives you've considered**
Alternative (if it is just for e.g. rendering), individual meshes can be exported and assembled again in the rendering software.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.