compas-dev / compas-dev/compas

Notes for visualisation parameters

Open
#1,370 0 comments 0 reactions 2 assignees Claimed by @tomvanmele View on GitHub
Dominant language
Python
Stars
386
Forks
122
Avg merge
11d 46m
Merged PRs (30d)
1

Description

LGTM. just a few notes/reminders

* `show_wires` (Blender) is actually the same as `show_lines`. `show_wires` is a better name in my opinion
* `disjoint` (Rhino) and `not shade_smooth` (Blender) are the same
* `Frame`, `Plane`, `Shape`, `Curve`, `Surface` should have dedicated base classes
* points of `Line`, `Polyline`, `Polygon`, `Polyhedron`, `Curve`, `Surface` are in fact "control points" and should perhaps have a dedicated color attribute for when they are turned "on".

_Originally posted by @tomvanmele in https://github.com/compas-dev/compas/pull/1353#pullrequestreview-2108294963_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.