commonmark / commonmark/cmark

Regarding commit 54b2be5 (warnings from clang)

Open
#624 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2k
Forks
691
Avg merge
1d 16h
Merged PRs (30d)
1

Description

I haven't taken the very first look at the actual code, so less "issue" and more "question" here:

Would it be feasible to re-enable the warning, and silencing it (where unwanted) either with pragmas, or by indirecting the "offending" (but best available) function calls into a separate inlined function that does nothing but forward to the warned-about call, with //NOLINT applied?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit 54b2be5 and the Clang warning configuration it changed. Identify the warning and the calls it reports, then determine whether unwanted diagnostics can be silenced while re-enabling the warning; done means the warning is active without introducing unwanted warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.