HTML comments do not follow the 0.30 spec
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 2k
- Forks
- 691
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 1
Description
cmark 0.30.3 does not follow the spec for Example 625 and Example 626.
Example input to cmark --unsafe:
foo <!-- not a comment -- two hyphens -->
foo <!--> foo -->
foo <!-- foo--->
Expected output:
<p>foo <!-- not a comment -- two hyphens --></p>
<p>foo <!--> foo --></p>
<p>foo <!-- foo---></p>
Actual output:
<p>foo <!-- not a comment -- two hyphens --></p>
<p>foo <!--> foo --></p>
<p>foo <!-- foo---></p>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First reproduce the discrepancy with cmark --unsafe using CommonMark Examples 625 and 626 and compare the actual HTML with the expected output in this report. Trace the HTML-comment parsing entry point in the cmark source and add or update coverage so all three inputs are rendered as escaped text rather than comments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, markdown
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100