commonmark / commonmark/cmark

[cmark --smart] paren-quote-markup combination

Open
#311 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2k
Forks
691
Avg merge
1d 16h
Merged PRs (30d)
1

Description

A plausible occurrence in a document is ("text"), which cmark --smart correctly turns into

(“text”)

However, if we emphasize the text,

("*text*")

we get

(”<em>text</em>”)

Note the incorrect right quote after the opening paren.

The same goes for the combination of a paren, a quote and other markup, such as strong
emphasis and references:

("**text**") --> (”<strong>text</strong>”)
("[text]")   --> (”<a href=...>text</a>”)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the documented examples with the cmark --smart entry point, comparing plain quoted text with emphasis, strong emphasis, and references. Trace how smart quotes are handled around rendered markup; done when an opening parenthesis followed by a quote produces an opening quote in all shown cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.