common-workflow-language / common-workflow-language/user_guide
Improve our Contributing guide regarding squashing commits
Open
good first issue
help wanted
type:discussion
type:enhancement
- Dominant language
- Common Workflow Language
- Stars
- 42
- Forks
- 65
- PR merge metrics
- No merged PRs in 30d
Description
One major issue blocking our release is the number of commits in the same PR, some not rebased.
Looking at the [current `CONTRIBUTING.md`](https://github.com/common-workflow-language/user_guide/blob/1dea5697b67b4750629b1cc60f39a09f262a7c5d/CONTRIBUTING.md#using-github), I think it's not direct about number of commits in a pull request.
This issue is a follow-up so we remember to update it as soon as we can. IMHO, we must not simply say "squash everything into a single commit", but we must ask contributors to only _not_ squash when it makes sense, but we can discuss that and see what others think about it too :+1:
Contributor guide
Assessment
This issue has not been assessed yet.