common-workflow-language / common-workflow-language/cwlviewer

Split database entities and response serialized objects (DTO)

Open
#379 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
52
Forks
29
Avg merge
5h 12m
Merged PRs (30d)
6

Description

It's normally considered a bad practice to have the database model classes also being used to send data to the user in responses.

It's better - and IMHO easier to maintain - to have the database model classes with its single responsibility, and move all de/serialization specifics to DTO's (or any other acronym like VO/POJO/DO/etc used in the project).

## Description

Part of #254 . Realized I was having to deal with the MongoDB specifics and also with how data is de/serialized :disappointed_relieved: It would have been a bit simpler should these two were separated entities.

## Expected Behavior

Separate classes, separate concerns.

## Actual Behavior

## Possible Fix

## Steps to Reproduce

NA

## Context

## Your Environment

* Version used:
* Environment name and version (e.g. Chrome 39, Java 1.8):

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.