common-workflow-language / common-workflow-language/cwltool

Resolving images with `_IMAGES` in `SingularityCommandLineJob` appears to write back to the wrong field

Open
#2,283 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
376
Forks
255
Avg merge
2d 7h
Merged PRs (30d)
12

Description

It looks like we write a resolved image to `dockerImage_id` here, but that field on the requirement is never read.

https://github.com/common-workflow-language/cwltool/blob/8949fc2d68efe128ce841739d1190645dbd233bb/cwltool/singularity.py#L234-L237

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.