common-workflow-language / common-workflow-language/cwltool

cwltool: Step using InplaceUpdate conflicts with still active readers from an already finished job

Open
#1,785 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
376
Forks
255
Avg merge
2d 7h
Merged PRs (30d)
12

Description

## Expected Behavior
cwltool should pass and not through an error

## Actual Behavior
cwltool throws an error

## Workflow Code
```
class: Workflow
cwlVersion: v1.2
id: minimal_example
label: minimal_example
inputs:
- id: msin
type: Directory[]
steps:
- id: compare_station_list
in:
- id: msin
source: msin
- id: station_list
default: "[CS001HBA0]"
out:
- id: filter_out
run: compare_station_list.cwl
label: compare_station_list
- id: subworkflow
in:
- id: msin
source: msin
- id: antennaconstraint
source: compare_station_list/filter_out
out:
- id: msout
run: subworkflow.cwl
scatter:
- msin
outputs:
- id: msout
outputSource:
- subworkflow/msout
type: Directory[]
requirements:
- class: ScatterFeatureRequirement
- class: SubworkflowFeatureRequirement
```
And this is the subworkflow:
```class: Workflow
cwlVersion: v1.2
id: subworkflow
label: subworkflow
inputs:
- id: msin
type: Directory
- id: antennaconstraint
type: string?
default: "[]"
steps:
- id: add_corrected_col
in:
- id: msin
source: msin
out:
- id: msout
run: dp3_addcol.cwl
label: add_corrected_col
outputs:
- id: msout
outputSource:
- add_corrected_col/msout
type: Directory
```
Steps for reference:
[compare_station_list.cwl](https://git.astron.nl/RD/LINC/-/blob/LBA_selfcal_1stloop/steps/compare_station_list.cwl)
[dp3_addcol.cwl](https://git.astron.nl/RD/LINC/-/blob/LBA_selfcal_1stloop/steps/dp3_addcol.cwl)

## Full Traceback
````
cwltool.errors.WorkflowException: [job add_corrected_col] wants to modify file:///data/LOFAR/LBA/A2069/working_directory/working_directory/8rbbgbbf/L368146_62MHz_uv-000.dp3concat but has readers: ['compare_station_list_2', 'compare_station_list_2', 'compare_station_list_2']`
````

## Your Environment
* cwltool version: 3.1.20220406080846

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.