common-workflow-language / common-workflow-language/cwltool

CWLProv: missing information in run with nested workflow

Open
#1,741 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
376
Forks
255
Avg merge
2d 7h
Merged PRs (30d)
12

Description

I ran [this workflow](https://github.com/ResearchObject/workflow-run-crate/tree/eab5f652670299b0a5493c3ab4fbf80a891d227d/tools/cwlprov_to_crate/revsortlcase) with `--provenance`, creating [this RO](https://github.com/ResearchObject/workflow-run-crate/tree/eab5f652670299b0a5493c3ab4fbf80a891d227d/tools/cwlprov_to_crate/test/data/revsortlcase-run-1).

![graph](https://user-images.githubusercontent.com/1183171/192995455-ae174374-1ce5-4f2d-bfa1-4e8a4771c3e1.svg)

There are two problems with the provenance:

1. There is no trace of the `revsort_in` parameter.
2. The `reverse_sort` parameter is reported as having a value of `False`, while it was actually set to `True`. The corresponding upstream (`descending_sort` in the main workflow) and downstream (`reverse` in `revtool.cwl`) parameters are correctly reported as `True`.

The RO was generated with cwltool 3.1.20220628170238, but I've verified that the issue is also present in the current version (3.1.20220913185150).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.