commercialhaskell / commercialhaskell/stack

Adopt `System.OsPath.OsPath` from `filepath >= 1.4.100.0`

Open
#5,858 0 comments 1 reaction 0 assignees View on GitHub
component: code quality type: enhancement
Dominant language
Haskell
Stars
4.1k
Forks
850
Avg merge
10h 37m
Merged PRs (30d)
4

Description

Stack currently uses `type FilePath = String` (as well as the types from package `path`). The authors of `filepath-1.4.100.0` recommend `OsPath` over `FilePath` as being 'more correct'.

GHC comes with `filepath`. For GHC 9.4.2, that is `filepath-1.4.2.2`.

`directory-1.3.8.0` depends on `filepath >= 1.4.100.0`. `fast-logger-3.1.1` depends on `directory`. However, it won't build with `directory-1.3.8.0` because its modules are no longer safe - see https://github.com/kazu-yamamoto/logger/issues/204.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.