commercialhaskell / commercialhaskell/stack

Unnecessary configuring on (almost?) any file change

Open
#5,578 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
4.1k
Forks
850
Avg merge
10h 37m
Merged PRs (30d)
4

Description

I've noticed that almost any time I have a file change in a project, `stack build` will run the Cabal configure step, slowing down compilations. I've traced this down to some issue with `stack-setup-config-mod`, and it appears that the file we're checking for dirtiness does not exist, triggering regular rebuilds.

I did a blame, and I think this comes down to this commit:

https://github.com/commercialhaskell/stack/commit/681ca331609e555d62e9aacbbc18770f81abd8de

It looks to me like `stack-setup-config-mod` is never being created in this commit. If I'm not mistaken, we need to add an equivalent to the `writeCabalMod` call that appears in this module.

CC @qrilka, I can take a stab at a PR, but input on this would be appreciated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.