commercialhaskell / commercialhaskell/stack

Completing repo package locations: ensure we use a SHA1

Open
#4,772 2 comments 1 reaction 1 assignee Claimed by @qrilka View on GitHub
component: build type: enhancement
Dominant language
Haskell
Stars
4.1k
Forks
850
Avg merge
10h 37m
Merged PRs (30d)
4

Description

We recommend throughout the Stack docs to always use an actual commit SHA for the `commit` field in repos. However, nothing enforces this, and (at least in the case of Git) it's possible to use any tree-ish. With lock files, it would make sense to ensure that we always lock to a specific commit SHA, regardless of what value is put in `commit` field.

Taking this one step farther: I think it would be possible to make the `commit` field entirely optional, which would have the semantics of cloning the default branch, finding the SHA of HEAD, and including that in the lock file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.