commercialhaskell / commercialhaskell/stack

Also have `--compiler` flag on CLI determine `--compiler-check`

Open
#2,442 0 comments 0 reactions 0 assignees View on GitHub
component: options parsing component: output (UI/UX) type: enhancement
Dominant language
Haskell
Stars
4.1k
Forks
850
Avg merge
10h 37m
Merged PRs (30d)
4

Description

Looking at the code, I noticed that the CLI is just used as an override for `compiler:` in the config / stackage snapshot. The `compiler-check` flag determines how strictly it's used. An unfortunate side-effect of this is that if you specify an exact version of ghcjs, it will ignore the 4th part of the version, which I suspect is happening in https://github.com/commercialhaskell/stack/issues/2436#issuecomment-237713600 .

How should this work? I think it should be based on the number of digits specified by the user in the version number. We could also consider using this for the compiler field within stack.yaml itself, though that's an iffier change.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.