commercetools / commercetools/sphere-node-sdk

Remove sku in product update action when setAttributeInAllVariants is used

Open
#346 0 comments 0 reactions 0 assignees View on GitHub
Type: Enhancement
Dominant language
CoffeeScript
Stars
16
Forks
8
PR merge metrics
No merged PRs in 30d

Description

### Description
When there's `setAttributeInAllVariants` action, there's no need to add sku to the update action. https://docs.commercetools.com/http-api-projects-products#set-attribute-in-all-variants

### Possible Solution
Use `delete action.sku` to remove sku. Check if this is the only place where sku should be removed.
https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/sync/utils/product.coffee#L545

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.