commercetools / commercetools/connect-application-kit

auth.middleware.{js,ts} scopes format does not conform to what SDK authmiddleware options require

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
12
Forks
5
PR merge metrics
No merged PRs in 30d

Description

In the auth.middleware.{js,ts} files in each of the connect applications, we have the following code

```typescript
scopes: [
readConfiguration().scope
? (readConfiguration().scope as string)
: 'default',
],
```

This code only works if the **CTP_SCOPE** env variable contains a single value such as **manage_project:xyz**

To make it work with values separated by spaces, **CTP_SCOPE=manage_customers:xyz manage_orders:xyz** we need to modify the code to split a long string into an array of strings.

Suggestion: modify the code as follows:

```typescript
scopes: readConfiguration().scope
? (readConfiguration().scope as string).split(' ')
: undefined,
```

The **undefined** is there to tell the system that, the middleware will use the scopes assigned to the API Client while it was being created via MC or API.

In the future, there could be a pre-defined scope but since this is a template, I think **undefined** is a good fit.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.