commercetools / commercetools/commercetools-sdk-php-v2
Fix more PHP 8.4 deprecation errors
- Dominant language
- PHP
- Stars
- 19
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
In the PR https://github.com/commercetools/commercetools-sdk-php-v2/pull/301 some deprecation errors were fixed. I updated to the 10.12.0 release, but still having PHP deprecation issues:
```
Deprecated: {closure:Commercetools\Client\MiddlewareFactory::createRetryNAMiddleware():69}(): Implicitly marking parameter $response as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/vendor/commercetools/commercetools-sdk/lib/commercetools-base/src/Client/MiddlewareFactory.php on line 74
```
```
Deprecated: Commercetools\Api\Client\Resource\ResourceByProjectKey::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/vendor/commercetools/commercetools-sdk/lib/commercetools-api/src/Client/Resource/ResourceByProjectKey.php on line 24
```
There are more than 1000 places where we should fix this. But seems these files are auto-generated, so seems we need to fix this in the generator, and then - regenerate the files.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.