Ford: `commIssue` due to `longitudinalPlan` checking `radarState` validity
Open
bug
- Dominant language
- Python
- Stars
- 63.7k
- Forks
- 11.4k
- Avg merge
- 17h 53m
- Merged PRs (30d)
- 171
Description
Due to 7c87ada8d80b72fb2c01d19c21722d63edccfd54
```
0ccc240e68e6034a/00000670--b7734ba37f/q
```
---
This is kind of an annoying case. The `commIssue` is expected here but not relevant since engaging is blocked in reverse gear anyway. This does however mess with our metrics, which understand a `commIssue` to always be a system malfunction.
To fix that, we can either:
1) `commIssue` and the like are irrelevant unless they block an engagement attempt
2) Try to separate out this case
I'm leaning towards option 1.
Contributor guide
Assessment
This issue has not been assessed yet.