commaai / commaai/openpilot

process not running alert can be shadowed

Open
#34,751 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
63.7k
Forks
11.4k
Avg merge
17h 53m
Merged PRs (30d)
171

Description

### Describe the bug

Encountered this when I went to help a new user drive on NMS Passat by taking it out of dashcam. They went straight into "LKAS Fault: Restart the car to engage". The immediate cause was PEBCAK, specifically a failure to pull my local dev environment to current, but the displayed alert led me astray when troubleshooting.

It looks like we properly raised `processNotRunning`, but unfortunately `steerUnavailable` displayed on top of it. The controls crash should be displayed first, both due to severity and due to the fact it will cause several other faults from the car.

### Provide a route where the issue occurs

ea1f52a90cc05090/00000001--1fc11d46d7

### openpilot version

29ff29bcb50e3f692216bb1441db9e6b58482cd1 plus PQ out of dashcam

### Additional info

onroadEvents at the time of the problem:

```
{'logMonoTime': 832553186941,
'onroadEvents': [{'enable': False,
'immediateDisable': True,
'name': 'steerUnavailable',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': True,
'preEnable': False,
'softDisable': False,
'userDisable': False,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'wrongGear',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': True,
'userDisable': False,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'seatbeltNotLatched',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': True,
'userDisable': False,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'wrongCarMode',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': False,
'userDisable': True,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'calibrationIncomplete',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': True,
'preEnable': False,
'softDisable': True,
'userDisable': False,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'pcmDisable',
'noEntry': False,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': False,
'userDisable': True,
'warning': False},
{'enable': False,
'immediateDisable': False,
'name': 'belowSteerSpeed',
'noEntry': False,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': False,
'userDisable': False,
'warning': True},
{'enable': False,
'immediateDisable': False,
'name': 'processNotRunning',
'noEntry': True,
'overrideLateral': False,
'overrideLongitudinal': False,
'permanent': False,
'preEnable': False,
'softDisable': True,
'userDisable': False,
'warning': False}],
'valid': True}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.